Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add / fix language identifiers in .md files across amphtml #25254

Merged
merged 1 commit into from
Oct 25, 2019
Merged

📖 Add / fix language identifiers in .md files across amphtml #25254

merged 1 commit into from
Oct 25, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Oct 25, 2019

Auto-formatting of .md files was introduced in #25182. This exposed several code blocks in our documentation with missing or incorrect language identifiers, and therefore missing or incorrect syntax highlighting / formatting.

PR highlights:

  • Adds several missing language identifiers
  • Fixes several incorrect language identifiers
  • Fixes some formatting bugs / typos
  • Adds prettier-ignore annotations where required
  • Reformats updated .md files with Prettier

Example before / after:

Reference: Github documentation for highlighting code blocks

Follow up to #25182

@amp-owners-bot
Copy link

Hey @gmajoulet, these files were changed:

  • extensions/amp-story/amp-story-bookend.md

Hey @newmuis, these files were changed:

  • extensions/amp-story/amp-story-bookend.md

@rsimha rsimha requested a review from mrjoro October 25, 2019 12:34
Copy link
Member

@mrjoro mrjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! I didn't check every file, but the ones I did look good.

@rsimha rsimha merged commit 532dbbb into ampproject:master Oct 25, 2019
@rsimha rsimha deleted the 2019-10-24-MarkdownSyntax branch October 25, 2019 16:34
twifkak added a commit to twifkak/amphtml that referenced this pull request Oct 30, 2019
@twifkak twifkak mentioned this pull request Oct 30, 2019
twifkak added a commit that referenced this pull request Oct 30, 2019
* cl/276564440 Add warnings about modifying public function interfaces.

* cl/277373856 Revision bump for #25246

* cl/277373931 Revision bump for #25254
@adligit2
Copy link

adligit2 commented Dec 1, 2019

Auto-formatting of .md files was introduced in #25182. This exposed several code blocks in our documentation with missing or incorrect language identifiers, and therefore missing or incorrect syntax highlighting / formatting.

PR highlights:

  • Adds several missing language identifiers
  • Fixes several incorrect language identifiers
  • Fixes some formatting bugs / typos
  • Adds prettier-ignore annotations where required
  • Reformats updated .md files with Prettier

Example before / after:

Reference: Github documentation for highlighting code blocks

Follow up to #25182

micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
* cl/276564440 Add warnings about modifying public function interfaces.

* cl/277373856 Revision bump for ampproject#25246

* cl/277373931 Revision bump for ampproject#25254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants